[CameraX • Compose] Migrate 3 Other Key CameraX Samples to Compose #312
Conversation
…from Android View
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @madebymozart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is the second phase of modernizing the camera-samples repository by converting more CameraX examples to Jetpack Compose. It focuses on migrating the Video, Extensions, and MLKit samples, providing fully Compose-based implementations that leverage declarative UI and simplified logic compared to their original XML counterparts.
Highlights
- Compose Migration: Migrated three key CameraX samples (Video, Extensions, and MLKit) from XML Views to Jetpack Compose, modernizing their UI and underlying logic.
- CameraX Extensions Sample: Introduced a new Compose sample demonstrating how to use CameraX Extensions (like Bokeh, HDR, Night) and switch between available extensions and camera lenses.
- CameraX MLKit Sample: Introduced a new Compose sample showcasing integration between CameraX and MLKit for real-time QR code detection in the camera feed, including drawing bounding boxes and handling interactions.
- CameraX Video Sample: Introduced a new Compose sample for basic video capture using CameraX, including handling recording state, saving video to MediaStore, and providing a simple playback screen.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully migrates three CameraX samples (Video, Extensions, MLKit) to Jetpack Compose. The changes involve re-architecting the UI layer, simplifying logic using Compose's declarative paradigm, and ensuring full Compose implementation. The code is generally well-structured and follows modern Android development practices.
I've identified a few areas for improvement, primarily related to resource management in the MLKit sample, potential null pointer exceptions, and an unused/buggy executor in the Video sample. These suggestions aim to enhance robustness and clarity.
samples/camera/camerax/src/main/java/com/example/platform/camerax/mlkit/CameraXMlKitSample.kt
Outdated
Show resolved
Hide resolved
| var barcodeScanner = remember { | ||
| BarcodeScanning.getClient( | ||
| BarcodeScannerOptions.Builder() | ||
| .setBarcodeFormats(Barcode.FORMAT_QR_CODE) | ||
| .build(), | ||
| ) | ||
| } |
There was a problem hiding this comment.
BarcodeScanner implements java.io.Closeable. It's important to close it when it's no longer needed to free up resources. Consider using DisposableEffect to close the scanner when the composable leaves the composition.
samples/camera/camerax/src/main/java/com/example/platform/camerax/mlkit/CameraXMlKitSample.kt
Outdated
Show resolved
Hide resolved
samples/camera/camerax/src/main/java/com/example/platform/camerax/mlkit/QrCodeViewModel.kt
Outdated
Show resolved
Hide resolved
| val localCameraExecutor = | ||
| remember { Executors.newSingleThreadExecutor() } // Or pass from parent |
There was a problem hiding this comment.
The localCameraExecutor initialized here appears to be unused for CameraX binding operations, as ProcessCameraProvider.addListener uses ContextCompat.getMainExecutor(context) and bindToLifecycle manages its own threading. This executor might be redundant.
| DisposableEffect(Unit) { | ||
| onDispose { | ||
| localCameraExecutor.isShutdown.not() | ||
| } | ||
| } |
There was a problem hiding this comment.
The onDispose block for localCameraExecutor currently contains localCameraExecutor.isShutdown.not(), which evaluates to a boolean but doesn't perform any action. If the intention was to shut down the executor, it should be localCameraExecutor.shutdown(). However, as noted in another comment, this executor might be unnecessary.
DisposableEffect(Unit) {
onDispose {
// If localCameraExecutor is deemed necessary and needs cleanup:
// localCameraExecutor.shutdown()
}
}
There was a problem hiding this comment.
@madebymozart Any reason it's localCameraExecutor.isShutdown.not(), but not localCameraExecutor.shutdown()? Gemini's review looks reasonable to me.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
madebymozart
requested review from
alabiaga,
ashnohe and
yrezgui
as code owners
madebymozart
requested review from
donovanfm
and removed request for
MagicalMeghan
- Update imports in CameraExtensionsViewModel.kt and QrCodeDrawable.kt. - Change `barcodeScanner` from `var` to `val` in CameraXMlKitSample.kt. - Update Log tag in CameraXMlKitSample.kt.
| * As is, this class only handles displaying the QR Code data if it's a URL. Other data types | ||
| * can be handled by adding more cases of Barcode.TYPE_URL in the init block. | ||
| */ | ||
| class QrCodeViewModel(barcode: Barcode) { |
There was a problem hiding this comment.
I'm not sure overall if this class name is adapted as it doesn't follow the usual logic of a view model on Android and a reference to the context shouldn't be extracted from the event listener but CameraX/MLKit API constraints make it hard to follow the Android way...
🚀 Jetpack Compose Migration for Camera Samples (Video, Extensions, MLKit)
📝 Description
This pull request continues our initiative to modernize the
camera-samplesrepository by converting existing XML View-based examples to Jetpack Compose.In this 2nd iteration, 3 key samples has been successfully migrated from their original implementations in the android/camera-samples repository. The migration involved:
✅ How Has This Been Tested?
Manual testing has been performed on the following configuration to ensure the core functionality of the migrated samples remains intact:
Test Configuration #1
Next Steps: